Add merge beacon block wrappers #9906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
changed the title
terencechain
added
Merge
rauljordan
approved these changes
Nov 24, 2021
| if b.ExecutionPayload == nil { | ||
| b.ExecutionPayload = ðpb.ExecutionPayload{ | ||
| ParentHash: make([]byte, 32), | ||
| FeeRecipient: make([]byte, 20), |
There was a problem hiding this comment.
These kinds of hard-coded sizes scare me. We should probably refactor later to use constants
There was a problem hiding this comment.
Same feedback as Raul, except I also question why we need to allocate all of this empty space?
There was a problem hiding this comment.
These are only used by tests, we typically do them before HTR or else HTR will complain incorrect list size. Example:
b := hydrate(block{slot:1})
r := hash_tree_root(b)
db.Save(r, b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds merge beacon block wrappers