Add Network Flags to Slashing Protection Export Command #9907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
approved these changes
Nov 15, 2021
prestonvanloon
approved these changes
Nov 15, 2021
delete-merged-branch
bot
deleted the
slashing-protection-right-network
branch
|
@potuz issue with exports is different. The user was storing the validator.db in one directory and the wallet keystores in another. They were then trying to export from the wallet directory, which in turn did not contain their validator.db. Addressing that now in another PR
There should be a way to create a "flag registration hook" or some higher-order function that applies common flags to all Prysm commands. I'll create a tracking issue for this one, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9905 by adding the --prater, --pyrmont, --mainnet flags to slashing protection exports. A user was mentioning that adding
--praterto the slashing protection export command still logs "Running on Ethereum consensus mainnet" instead of prater. This is scary to a user.