Monitor blocks #9910
Merged
Monitor blocks #9910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
force-pushed
the
monitor_blocks
branch
from
df90824 to
dc9a107
Compare
Merged
terencechain
requested changes
Nov 22, 2021
| } | ||
| state := s.config.StateGen.StateByRootIfCachedNoCopy(root) | ||
| if state == nil { | ||
| log.Debug("Skipping block due to state not found in cache") |
There was a problem hiding this comment.
I think log should be more descriptive. Seeing Skipping block due to state not found in cache over the console without knowing what feature this is could be useless
There was a problem hiding this comment.
the message would come prefixed by the monitor service. Do you want me to add a longer message?
potuz
force-pushed
the
monitor_blocks
branch
from
afef545 to
162b183
Compare
terencechain
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 5th PR for the validator monitor, in this PR we include logging and metrics for block proposals as well as triggering the logs for slashings/exits/etc that were already merged in previous PRs.