Alter config filed name to devnet if it's not populated in file #9949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, Prysm ships with an embedded genesis state. When loading custom genesis state with config name unchanged (i.e., mainnet), prysm will by default uses embedded genesis state which conflicts with to be loaded genesis state. (i.e.EMBEDDED_GENESIS_STATE.HTR() != LOADED_GENESIS_STATE.HTR()
). This is not ideal, and it's not quite right to assume that whenever config is unchanged, it's always going to useEMBEDDED_GENESIS_STATE.
It breaks much of the assumption of starting a new chain from scratch. The assumption that usesEMBEDDED_GENESIS_STATE
should be further restricted where deposit contract address and genesis fork version matchingEDIT:
Worked with @nisdas to find a more neutral way to alter mainnet field name in the event if it doesn't exist
credit to @parithosh for pointing this out