Update Libp2p to v0.15.1 #9960
Merged
Update Libp2p to v0.15.1 #9960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
reviewed
Dec 1, 2021
| return nil, err | ||
| } | ||
| return addr.Multiaddr(), nil | ||
| return ma.NewMultiaddr(address) |
There was a problem hiding this comment.
What's up with this, my not change then calls to multiAddrFromString?
There was a problem hiding this comment.
github.com/ipfs/go-ipfs-addr is deprecated and no longer works with new updates to github.com/multiformats/go-multiaddr
There was a problem hiding this comment.
I see what you are saying as feedback though. There is no longer a need to have this helper function.
Let's follow up refactor this in another PR to minimize changes.
prestonvanloon
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
Thanks!
Please note that this PR also updates go-ethereum to ethereum/go-ethereum@b97f57882c14.
This was a necessary update for #9772 and the update is not technically required for libp2p, but it seems safe to update anyway.
This was referenced Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Dependency Update
What does this PR do? Why is it needed?
go-libp2pto v0.15.1 and updates all its related transitive dependencies along with it.Which issues(s) does this PR fix?
This PR is split out from #9772 to make it smaller and more manageable to merge in separately.
Other notes for review