Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display Num Pruned Items in Slasher Only When Actually Prunes #9989

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Display Num Pruned Items in Slasher Only When Actually Prunes #9989

merged 2 commits into from
Dec 7, 2021

Conversation

rauljordan
Copy link
Contributor

In slasher, users see the following log every slot

Done pruning old proposals and attestations prefix=slasher numPruned=0

This is concerning because people may believe slasher is not pruning correctly. Instead, we display numPruned only if > 0

@rauljordan rauljordan requested a review from a team as a code owner December 7, 2021 02:12
@rauljordan rauljordan self-assigned this Dec 7, 2021
@prylabs-bulldozer prylabs-bulldozer bot merged commit 1eff00f into develop Dec 7, 2021
@delete-merged-branch delete-merged-branch bot deleted the log-num-pruned branch December 7, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terencechain terencechain terencechain approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@jmozah jmozah Awaiting requested review from jmozah jmozah is a code owner automatically assigned from prysmaticlabs/core-team

Assignees

@rauljordan rauljordan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rauljordan @terencechain