Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icons docs+isClickable panel prop #126

Merged
merged 3 commits into from
Mar 31, 2022
Merged

icons docs+isClickable panel prop #126

merged 3 commits into from
Mar 31, 2022

Conversation

GerardoPM
Copy link
Collaborator

Docs 🤘
@isClickable EuiPanel prop

@GerardoPM GerardoPM requested a review from betocantu93 March 31, 2022 19:34
betocantu93
betocantu93 requested changes Mar 31, 2022
View reviewed changes
packages/core/addon/components/eui-panel/index.hbs Outdated
@@ -4,6 +4,7 @@
(if (eq @grow false) "euiPanel--flexGrowZero")
(if (eq @hasBorder true) "euiPanel--hasBorder")
(if (eq @hasBorder false) "euiPanel--noBorder")
(if (eq @isClickable true) "euiPanel--isClickable")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The api should be @OnClick, there's no such @isClickable, basically if they provide an @OnClick function the isClickable would be applied

https://github.com/elastic/eui/blob/c6608a0ac6f48c66a0a43aa57a059a89c2fc4979/src/components/panel/panel.tsx#L135

Please always validate the implementation details on the corresponding component

@betocantu93 betocantu93 merged commit 0383bcf into feature/update-eui-styles Mar 31, 2022
@betocantu93 betocantu93 deleted the EuI-Icon-docs branch August 11, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betocantu93 betocantu93 betocantu93 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GerardoPM @betocantu93