This repository has been archived by the owner on Dec 3, 2023. It is now read-only.
Correct tests #210
Merged
Correct tests #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kikobeats
reviewed
Dec 12, 2018
| @@ -173,7 +173,8 @@ function call(urls, args1, args2, options, callback) { | |||
| } | |||
| } | |||
| } else { | |||
| args.push('--'); | |||
| if (i === 0) | |||
There was a problem hiding this comment.
Can you explain why this change is necessary? I don't understand it 🙂
Kikobeats
reviewed
Dec 12, 2018
| @@ -96,7 +96,7 @@ vows.describe('download').addBatch({ | |||
| assert.equal(progress, 1); | |||
| assert.isObject(data); | |||
| assert.equal(data.id, 'AW8OOp2undg'); | |||
| assert.equal(data.size, 34289); | |||
| // assert.equal(data.size, 49550); // No relevant, can be change through time | |||
There was a problem hiding this comment.
Why not remove it directly?
Kikobeats
reviewed
Dec 12, 2018
| @@ -51,7 +51,7 @@ vows.describe('getInfo').addBatch({ | |||
| }); | |||
| } | |||
| }, | |||
| 'from a youtube array of videos with one missing': { | |||
| /*'from a youtube array of videos with one missing': { | |||
There was a problem hiding this comment.
Happy to remove it if it is not useful
|
Thanks for that! feeling we need to merge it. Just review the change, waiting your replies 🙂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some test were corrected :
Question : What about getInfo->'from a youtube array of videos with one missing', one video is now unreachable on YT, so youtube-dl exit 1. What is the excepted result ?