Rl rename #136
Merged
Rl rename #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -426,10 +430,6 @@ - (void)peripheral:(CBPeripheral *)peripheral didUpdateNotificationStateForChara | |||
| NSLog(@"Updated notification state for %@, %@", characteristic, error); | |||
| } | |||
|
|
|||
| - (void)peripheralDidUpdateName:(CBPeripheral *)peripheral { | |||
| [[NSNotificationCenter defaultCenter] postNotificationName:RILEYLINK_EVENT_LIST_UPDATED object:nil]; | |||
There was a problem hiding this comment.
Are we no longer using this notification name? Can we remove it?
There was a problem hiding this comment.
…dd disclosure indicator to RL Name row, to indicate it can be edited
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reinstate RileyLink renaming feature. There is a delay after renaming, before we get the iOS callbacks that indicate the device is renamed. There should maybe be some progress UI to show that the renaming is happening, so users don't keep trying to rename. But going with this for now.