Adding a stateless upload path for Nightscout treatments #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. I'm curious as to how you'll handle upload failures in loop, but I guess that's my next place to review, and this change seems useful independent of what you're actually doing in loop. |
|
It will have a similar retry frequency (next history add, e.g. 5 min) as you have today. Changing this to I ran the stack overnight (with simulated uploading) and everything went well. History data and its upload status is also visible in the LoopKit-provided view controllers. |
ps2
pushed a commit
that referenced
this pull request
Aug 2, 2016
* Adding a stateless upload path for Nightscout treatments * Clarifying return order of history command
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.