Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish handler #91

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Finish handler #91

merged 2 commits into from
Jan 10, 2025

Conversation

fjtrujy
Copy link
Member

@fjtrujy fjtrujy commented Jan 10, 2025

Create specific functions to make it easier to deal with the finish handler interruption.
Additionally I have enabled also LTO

@rickgaiser
Copy link
Member

What happens to:

gsKit/ee/gs/src/gsCore.c

Lines 124 to 127 in 2897eec

void gsKit_finish(void)
{
while(!(GS_CSR_FINISH));
}

After registering a finish handler? Can they be used at the same time?

@fjtrujy
Copy link
Member Author

fjtrujy commented Jan 10, 2025

What happens to:

gsKit/ee/gs/src/gsCore.c

Lines 124 to 127 in 2897eec

void gsKit_finish(void)
{
while(!(GS_CSR_FINISH));
}

After registering a finish handler? Can they be used at the same time?

Yes, actually it is still being used

@rickgaiser
Copy link
Member

Then it LGTM

@fjtrujy fjtrujy merged commit b5afab2 into ps2dev:master Jan 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants