Revert "feat: libsd feature update" #774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 71e8c33.
|
@uyjulian let’s try to put back all these things in the near future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts PR #718
@uyjulian
Next time please add more description to your PR's. Like what is changed, and why we need that change. I now know nothing about the PR, except "libsd feature update". It's just a big blob of unknown change to me.
Also in case of issues, please take responsibility and try to figure out and help others why your PR broke something somewhere. I know it doesn't mean by definition that the issue is in the changed code. In this case it can just as good be an incompatibility on the OPL side. But I assume you know what you changed, and therefore also know where to look for issues. And please respond to questions, like these: #718 (comment)
Fixes #761
Fixes ps2homebrew/Open-PS2-Loader#1531
Partly fixes ps2homebrew/Open-PS2-Loader#1512
Fixes ps2homebrew/Open-PS2-Loader#1480
Probably fixes ps2homebrew/Open-PS2-Loader#1400
Probably fixes ps2homebrew/Open-PS2-Loader#1343