Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify release package #1337

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −5
Open

simplify release package #1337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflows/compilation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,6 @@ jobs:
title: "${{ steps.version.outputs.version }}"
files: |
OPNPS2LD-${{ env.OPL_VERSION }}.7z
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Id rather keep that for pre-release too. I remember that this was done specially for your scripts that were not able to correctly parse OPNPS2LD-${{ env.OPL_VERSION }}.7z naming

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was intended for direct download links

But duplicating the release assets only confuses people.

And the version number is clearly visible on the heading of the release card

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But after downloading you will loose that info. If you will have tons of OPNPS2LD.7z archives its a mess to understand which one is correct. I agree that packages should be reduced, but I am against the idea to keep commit-less naming. The only reason to keep short version of archive names, is your scripts, so I advice to change scripts to be able to parse more complex naming.

OPNPS2LD-VARIANTS-${{ env.OPL_VERSION }}.7z
OPNPS2LD-LANGS-${{ env.OPL_VERSION }}.7z
OPNPS2LD.7z
OPNPS2LD-VARIANTS.7z
OPNPS2LD-LANGS.7z
Expand All @@ -216,9 +214,6 @@ jobs:
OPNPS2LD-${{ env.OPL_VERSION }}.7z
OPNPS2LD-VARIANTS-${{ env.OPL_VERSION }}.7z
OPNPS2LD-LANGS-${{ env.OPL_VERSION }}.7z
OPNPS2LD.7z
OPNPS2LD-VARIANTS.7z
OPNPS2LD-LANGS.7z
- name: Upload pre-release to Mega
if: github.ref == 'refs/heads/master' && env.USERNAME != null
Expand Down