Cleanup of CDVDMAN/CDVDFSV #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use cd_file_t type instead of cdl_file_t, and move the extra flag entry into the RPC structure Add ifdef guards on some include files Move cdvdman default settings to ifdefs
This will make it easier to change it out to use sysclib when it is ready
AKuHAK
reviewed
Jun 26, 2021
There was a problem hiding this comment.
Also 2 new warnings appear in the compilation log:
mipsel-ps2-irx-gcc -D_IOP -fno-builtin -Os -G0 -Wall -I../../network/common -I../common -I/usr/local/ps2dev/ps2sdk/iop/include -I/usr/local/ps2dev/ps2sdk/common/include -I. -Iinclude/ -DSMB_DRIVER -D__USE_DEV9 -msoft-float -mno-explicit-relocs -c device-smb.c -o obj.smb/device-smb.o
device-smb.c: In function 'DeviceFSInit':
device-smb.c:84:31: warning: taking address of packed member of 'struct cdvdman_settings_smb' may result in an unaligned pointer value [-Waddress-of-packed-member]
84 | smb_OpenAndX(tmp_str, &cdvdman_settings.FIDs[i++], 0);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
device-smb.c:93:35: warning: taking address of packed member of 'struct cdvdman_settings_smb' may result in an unaligned pointer value [-Waddress-of-packed-member]
93 | smb_OpenAndX(tmp_str, &cdvdman_settings.FIDs[i], 0);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
|
Other looks good except for paranoid Codacy |
|
I made the mentioned changes, along with syncing the SCND/NCMD enumerations with ps2sdk. |
AKuHAK
approved these changes
Jun 26, 2021
|
Looks fine. If you dont plan to add something into this pr - it can be merged. |
This should make it more clear that it is an operation related to the sector size. The compiler should optimize it to bitshifts anyway
|
This is probably all I'm going to add into this pull request. |
citronalco
pushed a commit
to citronalco/OPL-Daily-Builds
that referenced
this pull request
Sep 10, 2023
Cleanup of CDVDMAN/CDVDFSV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description
Cleanups to CDVDMAN/CDVDFSV, mainly to make it easier to work with.
Source files have been split up and definitions have been changed to the ps2sdk ones.