lwNBDsvr: Small refactoring

[bignaux]

Pull Request checklist

Note: these are not necessarily requirements

• I reformatted the code with clang-format
• I checked to make sure my submission worked
• I am the author of submission or have permission from the original author
• Requires update of the PS2SDK
• Requires update of the gsKit
• Others (please specify below)

Pull Request description

[rickgaiser]

Please take a look at the codacy issues. Let me know when you're satisfied, then I'll pull the changes.

[bignaux]

Ok for me, still better. I get some ATAD error sometime like :

ATA device driver v1.2 - Copyright (c) 2003 Marcus R. Brown
atad: Driver loaded.
atad: Error: PIO cmd error: status 0x51, error 0x04.
atad: error: ATA failed, -503

on ata_get_devinfo but seems harmless and

atad: Error: DMA timeout.
atad: error: ATA failed, -502
atad: Timeout while waiting on busy (0x88).
atad: Timeout while waiting on busy (0x88).
atad: Timeout while waiting on busy (0x88).
atad: Timeout while waiting on busy (0x88).
atad: Timeout while waiting on busy (0x88).
``` during some transfert that could be better handle

[AKuHAK]

is it possible to get rid of all goto? Something like return ctx, or return null. Goto can lead to some problems in the future.

[AKuHAK]

If you want more description, you can define retcodes somewhere like
RET_ERROR = 0;
RET_SOFTDISCONNECT = -1;

[AKuHAK]

@bignaux

[AKuHAK]

for strlen warnings, maybe just for safety:

ctx->export_name[32] = '\0';
ctx-> export_desc[64] = '\0';

we use static arrays, I dont think that we will ofill the whole string, but for safety this can be assigned

[AKuHAK]

@bignaux

[AKuHAK]

Maybe all printf do only ifdef DEBUG ?? printf is a bit heavy function, can cause timeouts and slowdowns

[AKuHAK]

or use dbgprintf instead