Add on-screen keyboard example #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeldin
reviewed
Jun 13, 2020
samples/Makefile
Outdated
| @@ -1,4 +1,4 @@ | |||
| TARGETS := audio graphics input network spu sys | |||
| TARGETS := audio graphics input network osk spu sys | |||
|
|
|||
There was a problem hiding this comment.
This should go into samples/sys/Makefile, otherwise it will not work...
|
Thanks for your contribution. If you just fix the |
|
Oops! 🤦♂️ I just fixed my dumb mistake, sorry about that @zeldin 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the PS3 port of OpenSupaplex, I missed having an example of usage of the on-screen keyboard. Luckily, RetroArch used to have support for it and I could learn how to make it work.
This PR adds an osk example with what I have learned, and also one constant to detect when the user dismisses/cancels the osk. There are a few more constants here: https://github.com/Lexaundre/rpcs3-test/blob/196f985283adf08de5ba48c7377804f420a3b843/rpcs3/Emu/Cell/Modules/cellOskDialog.h#L23
But I don't know what they mean and I haven't needed them, so I decided to leave them out.