Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stubbing DBAL QueryBuilder #42

Closed
mpolyakovsky opened this issue Jan 9, 2020 · 2 comments
Closed

Stubbing DBAL QueryBuilder #42

mpolyakovsky opened this issue Jan 9, 2020 · 2 comments

Comments

@mpolyakovsky
Copy link
Contributor

Just wondering if there's any reason we do have stub for ORM QueryBuilder but don't have one for DBAL?

I could create one unless I miss something, just let me know.
@weirdan
Copy link
Member

weirdan commented Jan 10, 2020

Mostly because ORM QB support was contributed by an interested party (#26) and DBAL hasn't been yet 🤷‍♂️

Feel free to take a stab at it.

@mpolyakovsky mpolyakovsky mentioned this issue Jan 17, 2020
Merged
@weirdan
Copy link
Member

weirdan commented Jan 17, 2020

Fixed in #45

@weirdan weirdan closed this as completed Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weirdan @mpolyakovsky