Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of variadic arguments in QueryBuilder #26

Merged
merged 6 commits into from
Oct 13, 2019
Merged

Add support of variadic arguments in QueryBuilder #26

merged 6 commits into from
Oct 13, 2019

Conversation

2e3s
Copy link
Contributor

@2e3s 2e3s commented Oct 12, 2019

@creocoder
Copy link

Great addition for great plugin.

2e3s and others added 5 commits October 12, 2019 18:11
@2e3s
Divide first argument and variadic arguments
8c90cbb
@2e3s
Fix tests for older Psalm version
39436d6
@2e3s
Fix using Func for selects
a07ab2d
@weirdan
Replaced generics with typedefs
56b7f12 
- Replaced type arguments with typedefs as neither QueryBuilder nor its
methods are really generic
- Clarified QueryBuilder method signatures
@weirdan
Tweaked tests
e2bc24f 
- Fixed description
- Added a couple of negative tests
@weirdan weirdan merged commit 252ed6b into psalm:master Oct 13, 2019
@weirdan
Copy link
Member

weirdan commented Oct 13, 2019

Released as 0.7.0

@2e3s 2e3s deleted the query-builder branch October 13, 2019 05:47
@weirdan weirdan mentioned this pull request Jan 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weirdan weirdan weirdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2e3s @creocoder @weirdan