Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Connection::prepare() return type #146

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

2e3s
Copy link
Contributor

@2e3s 2e3s commented Jul 14, 2023

@2e3s
Copy link
Contributor Author

2e3s commented Jul 14, 2023

I'm not clear on failures because if run locally, the result is the same with or without the change. CI seems broken on the main branch?

@orklah
Copy link
Collaborator

orklah commented Jul 14, 2023

Tests have been failing for some time, no need to worry :) maybe @weirdan will find time to look at this :)

Thanks!

@orklah orklah merged commit ae11594 into psalm:2.x Jul 14, 2023
@weirdan
Copy link
Member

weirdan commented Jul 14, 2023

That would be after I get back to Psalm core (read: not very soon). Based on how it goes here I probably won't look into these test failures this year.

@2e3s 2e3s deleted the connection-prepare-return branch July 14, 2023 17:33
@2e3s 2e3s mentioned this pull request Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants