Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add laravel 11 support #362

Closed
wants to merge 12 commits into from
Closed

Conversation

mokhosh
Copy link

@mokhosh mokhosh commented Feb 25, 2024

I haven't updated the readme as I'm not sure whether you will add this to a new tag or not. Can do that after confirming your decision.

Copy link
Collaborator

@alies-dev alies-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, @mokhosh thanks a lot! I'm really glad that someone helped me to contribute to this package! 💪

Based on https://github.com/psalm/psalm-plugin-laravel/actions/runs/8037576434/job/21955406945, don't we need to also install orchestra/testbench of 9/dev version?

@mokhosh
Copy link
Author

mokhosh commented Feb 26, 2024

No worries man, glad I could help.

Added Testbench 9 to Laravel 11 workflows.

@mokhosh
Copy link
Author

mokhosh commented Feb 26, 2024

We're out of composer dependency and github workflow issues.
We're getting some Psalm RiskyTruthyFalsyComparison errors in different tests, however.

@alies-dev
Copy link
Collaborator

alies-dev commented Mar 12, 2024

Sorry @mokhosh, I appreciate your work on this PR, but there is another one PR , more comprehensive one, that solves the same problem: #364

@alies-dev alies-dev closed this Mar 12, 2024
@mokhosh
Copy link
Author

mokhosh commented Mar 12, 2024

@alies-dev it's ok, man.

@mokhosh mokhosh deleted the add-laravel-11-support branch March 12, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants