Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump dependencies: drop Laravel 10 and PHP 8.1 support #388

Merged
merged 41 commits into from
Feb 16, 2025

Conversation

alies-dev
Copy link
Collaborator

@alies-dev alies-dev commented Feb 2, 2025

Drop Laravel 10 to focus on limited resources for better Laravel 11 support.

Closes #387

@alies-dev alies-dev self-assigned this Feb 2, 2025
@tm1000
Copy link
Contributor

tm1000 commented Feb 6, 2025

Just curious what is the issue with No hint path defined for [ide-helper] ??

@danog
Copy link
Contributor

danog commented Feb 6, 2025

Not sure tbh...

@alies-dev
Copy link
Collaborator Author

@tm1000

Just curious what is the issue with No hint path defined for [ide-helper] ??

This is caused by the way this plugin uses ide-helper. The quick fix is to pass a read instance of View Factory to the Barryvdh\LaravelIdeHelper\Console\GeneratorCommand:

        $stubs_generator_command = new GeneratorCommand(
            $config,
            $fake_filesystem,
-           ViewFactoryProvider::get(),
+           $app->make('view')
        );

But there are some more issues, also caused by ide-helper. The goal of this PR is to fix all of them and then ideally drop ide-helper dependency entirely, as it produces a lot of issues like this (mostly because it's not created in a way this plugin uses it and constantly creates BC changes). I need more time to finish this work, with some cache I'll finish it this (first step) weekend.

@tm1000
Copy link
Contributor

tm1000 commented Feb 11, 2025

@alies-dev checkin to see how its going and if I'd be able to help. I tried to pull in your branch but psalm crashes with "event loop is already running"

@alies-dev
Copy link
Collaborator Author

Hey @tm1000

Thanks for checking in! Your interest actually helps validate that this plugin is still relevant to the community. I've been wondering about its place given Larastan's inclusion in Laravel's default stack.

I'm planning to spend some time on the plugin this weekend. If you're interested in contributing, I'll share some easy-wins we can solve together. WDYT?

Having active contributors would definitely help maintain momentum on this project. 🤍

@alies-dev alies-dev added the release:major for PRs only (used by release-drafter) label Feb 16, 2025
@alies-dev alies-dev merged commit 6f98635 into psalm:master Feb 16, 2025
7 checks passed
@alies-dev alies-dev deleted the dump-dependencies branch February 16, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:major for PRs only (used by release-drafter)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Psalm 6
3 participants