consider dropping support for phpunit < 8 in a major release #53
Comments
SignpostMarv
added a commit
to SignpostMarv/phpunit-psalm-plugin
that referenced
this issue
Feb 7, 2020
supporting newer versions of phpunit leads to an issue where if `Foo extends TestCase` and `TestCase::setUp()` does not explicitly return void, failure occurs. see psalm#53
|
@SignpostMarv: If you don't mind can you check the link in you report? I don't get anything useful when I open it. And per the title, did you mean "new" major release? In any case, I had problems to find out wich Phpunit version are to be supported by the plugin and also wondered if it may even there is a requirement of having different plugins per Phpunit version. So far I'm fine to not drop 7.5x support from all the releases from my end. |
|
have updated the link. as for "new", yeah- you wouldn't want to drop support for a phpunit version in a minor/patch release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
as per failures on:
https://travis-ci.org/psalm/phpunit-psalm-plugin/jobs/647313805?utm_medium=notification&utm_source=github_statushttps://travis-ci.org/github/psalm/psalm-plugin-phpunit/jobs/647313805The text was updated successfully, but these errors were encountered: