-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent PropertyNotSetInConstructor #142
base: master
Are you sure you want to change the base?
Conversation
@Punk-UnDeaD thank you for your contribution. Could you please rebase your branch or merge with up-to-date master to pass the tests? |
25380ac
to
aa267ec
Compare
|
||
final class MyServiceB { | ||
/** @required */ | ||
public MyServiceA $a; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately this is not working for < PHP 7.4
9f89da0
to
19dba20
Compare
Prevent PropertyNotSetInConstructor when ContainerAwareTrait used.
What's the status here, you need some help or anything? CI is failing, so it can't really be expected to be merged in this state. |
@ostrolucky i fixed all my issues, but tests failed on 'Class 'Symfony\Component\BrowserKit\AbstractBrowser' not found' and i don't know how to skip this |
I fixed all the tests issue in #242, maybe this PR could be rebased after the merge of mine @seferov @Punk-UnDeaD ? |
Just a heads up: There already is a handler for the annotation in |
Any progress on this? |
Support @reqired annotation and #[Required] attribute for properties.
Prevent PropertyNotSetInConstructor when ContainerAwareTrait used.
for #141 and #140