Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal legend in columns #2

Merged
merged 1 commit into from
Jul 26, 2016
Merged

Horizontal legend in columns #2

merged 1 commit into from
Jul 26, 2016

Conversation

psalmody
Copy link
Owner

What do you think @n-riesco? This should work?

I've found that legend positioning has issues with the graph I've been testing when layout.width < 780 but I I'm pretty sure it's related to something else, not an issue with this section rendering the legend.

newplot 2

@psalmody
Copy link
Owner Author

psalmody commented Jul 26, 2016

@n-riesco Would it be best to merge this into PR #1 or as a separate issue on plotly and separate PR? I'm thinking it makes most sense for horizontal margins to not push into the margin.

@n-riesco
Copy link

What happens with layout.width < 780 is how legends are meant to work. Plotly tries to position the legend where the user requested and finds that portions of the legend go beyond the visible area. When this happens, Plotly relocates and resizes the legend to make it fit within the plot area. Here's the logic where this happens.

@n-riesco
Copy link

I think horizontal legends look much better like this. I would merge this PR into #1 and see what Étienne thinks.

@psalmody psalmody merged commit 7ef2dff into h-legend-wrap Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants