Option to treat exceptions as equivalent #328
Conversation
There was a problem hiding this comment.
I know this is draft, so you probably aren't even ready for a review, but I also figure that delaying feedback never helps 😄. This is looking great, and I am excited about it! Some overall notes:
- Append yourself to
contributing.rst! Most people link to their github, but any self-promotion link you want is fine. precommit -ahopefully will hopefully help you get past the current CI complaints.- Related, I'd love to hear any stumbling blocks you might have encountered while getting a working dev environment set up!
Abhiram98
force-pushed
the
exceptions-equivalent
branch
from
cbcd268 to
25fbd39
Compare
instead of returning the exception directly. unpack IgnoreAttempt while displaying lint
Abhiram98
force-pushed
the
exceptions-equivalent
branch
from
25fbd39 to
88c5146
Compare
Update diff_behavior.py
Abhiram98
changed the title
Abhiram98
force-pushed
the
exceptions-equivalent
branch
from
687a83d to
6ebde1e
Compare
crosshair/diff_behavior.py
Outdated
| if flexible_equal(args1, args2) and ( | ||
| flexible_equal(result1[0], result2[0]) # Compare only the results. | ||
| ): |
There was a problem hiding this comment.
Swap the order of these clauses to fix that strange test_diff_behavior_nan failure. (flexible_equal(result1[0], result2[0]) and flexible_equal(args1, args2))
There's actually a latent bug in the nan comparison thing I just did, but it only gets exposed because you've changed the order of the comparison, and that's enough to make the system pick different paths in the test. I'll fix the root cause separately (and increase the iterations in the test so that we would be able to detect a regression in the future)
to fix nan issue undo lint
Abhiram98
force-pushed
the
exceptions-equivalent
branch
from
caf6ae5 to
2b55f2b
Compare
|
Thanks Phillip! I am also surprised about the conflicts. I tried merging the main into the working branch, hopefully that resolves it? I cannot see a conflict on the PR |
|
Supposed merge conflicts were having trouble; I ended up squashing and committing in 8ed4356 Thank you @Abhiram98 ! |
For #324