-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bridge-api): switch from hashed tokens to encrypted tokens #85
Conversation
Thanks for implementing this! I wonder though if this works with older bridge (software) versions, I'm assuming it doesn't - right? If that's the case we should make this pynuki 2.0 release, rather than a simple patch bump. |
As for the docs it seems to be compatible even with older bridges:
That's why I decided to replace the hash_token instead of adding to it :) I guess the only bridge that won't be supported anymore by pynuki would be the software bridge, which isn't supported by nuki anymore since nearly two years. I can of course change the version to |
If you don't mind, I'd love if you can add the |
This seems to break the discovery feature:
|
Thanks for the review and the fixes! :) |
fixes #84