Skip to content

Commit

Permalink
Address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
joshua-bone committed Jan 13, 2021
1 parent 6a28332 commit fa2df97
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions kubetest2-gke/deployer/firewall.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,13 @@ func ensureFirewallRulesForMultiProjects(projects []string, network string, subn
hostProject := projects[0]
hostProjectNumber, err := getProjectNumber(hostProject)
if err != nil {
return fmt.Errorf("error looking up project number for id %v. Original error: %v", hostProject, err)
return fmt.Errorf("error looking up project number for id %q: %w", hostProject, err)
}
for i := 1; i < len(projects); i++ {
curtProject := projects[i]
curtProjectNumber, err := getProjectNumber(curtProject)
if err != nil {
return fmt.Errorf("error looking up project number for id %v. Original error: %v", curtProject, err)
return fmt.Errorf("error looking up project number for id %q: %w", curtProject, err)
}
firewall := fmt.Sprintf("rule-%s-%s", hostProjectNumber, curtProjectNumber)
// sourceRanges need to be separated with ",", while the provided subnetworkRanges are separated with space.
Expand Down

0 comments on commit fa2df97

Please sign in to comment.