MATLAB R2016b compatibility #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s on R2016b and later The `initTestSuite` can no longer be used in R2016b and later, due to the way scripts are scoped in those versions. Instead the `buildFunctionHandleTestSuite` function should be used. In fact, this is the preferred way for generating these types of test suites across all MATLAB versions that support them. `initTestSuite` has been updated to generate warnings about the changed behavior in R2016b and errors out with a descriptive error on affected versions. And documentation is available in `buildFunctionHandleTestSuite` describing how to support older MATLAB versions. Fixes psexton#19.
Closed
|
All tests pass in {13b, 14a, 14b, 15a, 15b, 16a, 16b} * {Win7 64-bit, Linux 64-bit}. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains compatibility fixes for MATLAB R2016b. The most important one of which is a fix for
initTestSuite, which no longer works in versions post-R2016b. As was also reported by @amroamroamro in #19. Our solutions are mostly similar.This fix proposes an alternative
buildFunctionHandleTestSuitefunction for these versions, and implements an alternativeinitTestSuitescript employing this new function.I'm aware of one issue with using
buildFunctionHandleTestSuiteon older versions of MATLAB (prior to R2014b), which is related to getting a cell array of handles to local functions. In versions prior to R2013b thelocalfunctionscommand does not even exist, and between R2013b and R2014b it doesn't properly detect local functions for packaged functions. I have tried to abstract these different approaches into a single function call, but haven't been able to get that to work. This function would look similar to code currently ininitTestSuite, but as soon as the code getting the list of function handles gets pushed into a function, obtaining correctly functioning function handles, no longer works. The alternate approach to callingbuildFunctionHandleTestSuitewhenlocalfunctionsis not available is outlined in the documentation forbuildFunctionHandleTestSuite.