GREP for PR reference accepts references that are split over a line #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please can a contributor add the "skip-news" label to this PR since this is fixing a bug in one of the github workflows it does not affect the behaviour of black. |
ichard26
approved these changes
Mar 28, 2021
There was a problem hiding this comment.
Hey thanks for the PR! Looks good to me!
Pro-tip: use a keyword to have GitHub automatically close an issue when a PR is merged. This helps keep our (very chaotic) issue tracker slightly less chaotic :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2070 by changing grep pattern used to search for the reference PR number in the github changelog workflow to be
This matches
PR #1234orso CHANGES.md is still acceptable even if prettify requires that the PR reference be formatted to be split across two lines.