remove regex dependency #2663
Merged
remove regex dependency #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can handle the pipenv related changes as I suspect the changes might break compatibility with older versions of Python. |
|
I spoke too soon, there's another thing to fix in trans.py. |
ichard26
reviewed
Dec 2, 2021
This was
linked to
issues
Dec 2, 2021
Thanks! Feel free to push to this branch. Hopefully I got CI clean this time. |
cooperlees
approved these changes
Dec 2, 2021
| @@ -101,7 +101,6 @@ def find_python_files(base: Path) -> List[Path]: | |||
| "platformdirs>=2", | |||
| "tomli>=0.2.6,<2.0.0", | |||
| "typed-ast>=1.4.2; python_version < '3.8' and implementation_name == 'cpython'", | |||
| "regex>=2021.4.4", | |||
| @@ -453,7 +453,7 @@ def make_naked(string: str, string_prefix: str) -> str: | |||
| # with 'f'... | |||
| if "f" in prefix and "f" not in next_prefix: | |||
| # Then we must escape any braces contained in this substring. | |||
| SS = re.subf(r"(\{|\})", "{1}{1}", SS) | |||
| SS = re.sub(r"(\{|\})", r"\1\1", SS) | |||
There was a problem hiding this comment.
This will never have unicode to match right so we should be safe ... :D
There was a problem hiding this comment.
As far as I can tell the missing unicode support is just about character classes, so some "word" characters don't match \w in re but do in regex. That doesn't apply here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were no longer using it.