Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move configurations to pyproject.toml #3632

Closed
wants to merge 10 commits into from
Closed

chore: move configurations to pyproject.toml #3632

wants to merge 10 commits into from

Conversation

SauravMaheshkar
Copy link

Description

This PR aims to minimize the number of configuration files for the project. Instead of a separate .coveragerc and mypy.ini, we now would have all the configurations within the pyproject.toml file leading to a overall minimal code structure.

Checklist

  • Add an entry in CHANGES.md if necessary? (skip news ??)
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@JelleZijlstra JelleZijlstra added the skip news Pull requests that don't need a changelog entry. label Mar 30, 2023
Secrus
Secrus reviewed Apr 2, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@SauravMaheshkar SauravMaheshkar requested a review from Secrus April 28, 2023 19:51
@SauravMaheshkar
Copy link
Author

@JelleZijlstra Request for Review

@JelleZijlstra JelleZijlstra requested review from JelleZijlstra and removed request for Secrus May 15, 2023 21:55
cooperlees
cooperlees requested changes May 15, 2023
View reviewed changes
Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we need:

  • toml support for coverage
  • mypy is very unhappy now showing lots of type errors
    • Haven't looked - but are these valid or problem with getting it's settings from the toml?

@SauravMaheshkar SauravMaheshkar deleted the refactor branch May 31, 2023 20:59
@acharles7 acharles7 mentioned this pull request Oct 9, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Secrus Secrus Secrus left review comments

@cooperlees cooperlees cooperlees requested changes

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees
No one assigned
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SauravMaheshkar @cooperlees @Secrus @JelleZijlstra