-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Black PyCharm 2023.2 integration instructions #3839
Conversation
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
for more information, see https://pre-commit.ci
docs/integrations/editors.md
Outdated
@@ -21,6 +22,17 @@ The first option is the simplest to set up and formats the fastest (by spinning | |||
startup cost on subsequent formats), but if you would prefer to not install a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes what "the first option" in this paragraph refers to; I think needs some reworking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this?
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (though I don't use PyCharm and haven't tried this).
@hauntsaninja are you OK with this PR now? (I can't merge since you requested changes.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me (also do not use pycharm and haven't tried)
I'm a bit uncreative as to what users might want to configure there
Description
Checklist - did you ...
CHANGES.md
if necessary?