-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4011: Handle more huggable immediately nested parens/brackets. #4012
Conversation
for more information, see https://pre-commit.ci
diff-shades results comparing this PR (240c218) to main (58f31a7). The full diff is available in the logs under the "Generate HTML diff report" step.
|
Looks like the changelog checker doesn't like me combining two PRs in CHANGES.md, let me know if you prefer separating them. |
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Looking at diff shades, this explodes: -man_pages = [
- ("index", doc_module.__name__, doc_module.__name__ + " Documentation", [""], 1)
-]
+man_pages = [(
+ "index",
+ doc_module.__name__,
+ doc_module.__name__ + " Documentation",
+ [""],
+ 1,
+)] - c = Context({
- "version": get_docs_version(),
- })
+ c = Context(
+ {
+ "version": get_docs_version(),
+ }
+ ) I'll take a look later. |
…hades issues." This reverts commit 6134969.
diff-shades finally succeeded after several retries. I tried my best to read through the preview diffs, and they all look expected to me. |
This keeps two blank lines between the module docstring and the following def/class when there are no other code in between. Why cherrypick not rebase? Pyink is not yet ready to rebase to Black 23.11.0 yet, I'm waiting for psf#4012 to be merged as Pyink has local patches related by hugging parens. PiperOrigin-RevId: 582472645
This keeps two blank lines between the module docstring and the following def/class when there are no other code in between. Why cherrypick not rebase? Pyink is not yet ready to rebase to Black 23.11.0, I'm waiting for psf#4012 to be merged as Pyink has local patches related to hugging parens. PiperOrigin-RevId: 582472645
This keeps two blank lines between the module docstring and the following def/class when there are no other code in between. Why cherrypick not rebase? Pyink is not yet ready to rebase to Black 23.11.0, I'm waiting for psf#4012 to be merged as Pyink has local patches related to hugging parens. Also added two missing patches. PiperOrigin-RevId: 582472645
This keeps two blank lines between the module docstring and the following def/class when there are no other code in between. Why cherrypick not rebase? Pyink is not yet ready to rebase to Black 23.11.0, I'm waiting for psf#4012 to be merged as Pyink has local patches related to hugging parens. Also added two missing patches. PiperOrigin-RevId: 582704838
Description
Fix #4011.
Checklist - did you ...
CHANGES.md
if necessary?