fix: Don't remove parenthesis around long dictionary values #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cobaltt7
commented
Jun 6, 2024
Signed-off-by: cobalt <61329810+RedGuy12@users.noreply.github.com>
for more information, see https://pre-commit.ci
cobaltt7
changed the title
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
|
Ready for review. Not sure why CI is failing; seems unrelated to my PR. |
JelleZijlstra
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4158 (
string_processingandwrap_long_dict_values_in_parens)Resolves #3452 (
wrap_long_dict_values_in_parens)Slightly refactors
_maybe_split_omitting_optional_parens()by moving some conditions for omitting optional parens into_prefer_split_rhs_oop_over_rhs()for simpler code logicFixes some typos in comments and error messages in
trans.pythat I found while debuggingI believe
wrap_long_dict_values_in_parensis now ready to move from the unstable to preview style. Let me know if this is desirable in this PR.Checklist - did you ...
CHANGES.mdif necessary?