Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs CI #4555

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Fix docs CI #4555

merged 1 commit into from
Jan 21, 2025

Conversation

MeGaGiGaGon
Copy link
Collaborator

@MeGaGiGaGon MeGaGiGaGon commented Jan 21, 2025 •
edited
Loading

Description

Docs CI is now failing thanks to

The sphinx.configuration key is missing. This key is now required, see our blog post for more information.

It looks like black does the same thing as the .readthedocs.yaml example from that post, so I just copied it.

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@MeGaGiGaGon MeGaGiGaGon changed the title Fix docs CLI Fix docs CI Jan 21, 2025
@hauntsaninja hauntsaninja added the skip news Pull requests that don't need a changelog entry. label Jan 21, 2025
hauntsaninja
hauntsaninja approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@hauntsaninja hauntsaninja merged commit 1455ae4 into psf:main Jan 21, 2025
43 of 44 checks passed
@MeGaGiGaGon MeGaGiGaGon deleted the patch-2 branch January 21, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MeGaGiGaGon @hauntsaninja