Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .eggs to default exclusions #629

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

BeyondEvil
Copy link
Contributor

@BeyondEvil BeyondEvil commented Nov 29, 2018

If you have a package that you publish using setuptools_scm and you use tox to run tests etc., you end up with an .eggs directory. I think it is safe to assume this can be excluded by default.

We use tox in our CI and use black with the --check flag, which then fails because black formats the .py-files inside the .eggs folder generated by tox.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 823

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.095%

Totals Coverage Status
Change from base Build 822: 0.0%
Covered Lines: 2904
Relevant Lines: 3022

💛 - Coveralls

3 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 823

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.095%

Totals Coverage Status
Change from base Build 822: 0.0%
Covered Lines: 2904
Relevant Lines: 3022

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 823

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.095%

Totals Coverage Status
Change from base Build 822: 0.0%
Covered Lines: 2904
Relevant Lines: 3022

💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 29, 2018

Pull Request Test Coverage Report for Build 823

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.095%

Totals Coverage Status
Change from base Build 822: 0.0%
Covered Lines: 2904
Relevant Lines: 3022

💛 - Coveralls

@JelleZijlstra JelleZijlstra merged commit 5512119 into psf:master Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants