fix: response leak when using caching adapter and streaming #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tasssadar
commented
Dec 13, 2024
Comment on lines
-142
to
-143
| response._update_chunk_length = types.MethodType( # type: ignore[method-assign] | ||
| _update_chunk_length, response |
There was a problem hiding this comment.
When you assign a method like this, you're creating a circular reference to self, because when you normally call response._update_chunk_length, it actually creates the bound method on-the-fly, it's not set there all the time.
This SO response helped me understand it: https://stackoverflow.com/a/26158130
frostming
reviewed
Dec 13, 2024
frostming
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Good catch and fix. I would like to accept this. And I will wait for the inputs from @woodruffw
woodruffw
approved these changes
Dec 13, 2024
|
Hi, when can we expect this being released to pypi? |
Assuming nothing else comes up, I'll cut a release in the next day or so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this library breaks
requestsbehavior, where the finalizer will close response if user forges to call close. Use WeakRefs to prevent this.