Use the official Python logo #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By default, the logo has a shadow beneath it, which causes the portrait rectangle to be squashed as a favicon: 
Perhaps use the one at https://github.com/python/devguide/blob/main/_static/python-logo.svg instead, which has the shadow removed? |
Use a custom logo for the theme's logo and favicon as documented in the [Material for MkDocs documentation]. This replaces the theme's default logo in the navbar and the favicon. The included logo is from the [Python Developer's Guide], but other versions are available. [Material for MkDocs documentation]: https://squidfunk.github.io/mkdocs-material/setup/changing-the-logo-and-icons/#logo [Python Developer's Guide]: https://devguide.python.org/
|
@hugovk Thanks, I've updated my PR with your suggestion. Contrast with the background is also a concern, and that is something that would require additional theme changes (i.e. the color of the header / navbar). I am not aware of brand guidelines regarding background colors, there's still room for improvement here. |
|
Thanks, the favicon looks better: 
Yeah, I see what you mean about the contrast between the "Blueberry Memories" header and the blue snake of the logo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should this project use the official Python logo for the MkDocs theme logo and favicon? I've opened this as a quick PR instead of filing an issue because it's only a two line change.
Maintainers should please feel free to make edits to this PR or replace it with something else.
Commit message included below:
Use a custom logo for the theme's logo and favicon as documented in the Material for MkDocs documentation. This replaces the theme's default logo in the navbar and the favicon. The included logo is from the Python Developer's Guide, but other versions are available.