Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issue regarding memory units (kB vs KiB) #198

Closed
yngvem opened this issue Aug 8, 2024 · 2 comments · Fixed by #199
Closed

Minor issue regarding memory units (kB vs KiB) #198

yngvem opened this issue Aug 8, 2024 · 2 comments · Fixed by #199

Comments

@yngvem
Copy link
Contributor

yngvem commented Aug 8, 2024

The units in the output when track-memory is enabled say kB and MB. However, as far as I can tell, the correct units are KiB and MiB? It's a minor issue, and might not be worth changing due to the hassle of changing the output for downstream applications, but I found it confusing at first that the summary didn't match up with the actual numbers in the JSON file.

I wasn't sure if it was worth opening an issue for such a minor issue, but I thought it might be worth making a concious decision on whether to use precise SI units.

Sorry if there's already been a discussion on this, I tried looking but I couldn't find anything.

@vstinner
Copy link
Member

vstinner commented Aug 9, 2024

Do you want to propose a pull request fixing the issue?

@yngvem
Copy link
Contributor Author

yngvem commented Aug 9, 2024

I can give it a shot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants