Use KiB and MiB as units instead of kB and MB. #199

yngvem · 2024-08-09T19:05:45Z

Previously, pyperf stated the memory usage as kB and MB, while strictly speaking, it was measured in KiB and MiB.
This commit makes it clear that the memory is measured using 2^10 and 2^20 bytes, not 10^3 and 10^6.

Closes #198

Example output:

$ python3 -m pyperf timeit '[1,2]*1000' --track-memory
.....................
Mean +- std dev: 10.2 MiB +- 78.2 kiB

Previously, pyperf stated the memory usage as kB and MB, while strictly speaking, it was measured in KiB and MiB. This commit makes it clear that the memory is measured using 2^10 and 2^20 bytes, not 10^3 and 10^6.

vstinner

LGTM

Use KiB and MiB as units instead of kB and MB.

35506d3

Previously, pyperf stated the memory usage as kB and MB, while strictly speaking, it was measured in KiB and MiB. This commit makes it clear that the memory is measured using 2^10 and 2^20 bytes, not 10^3 and 10^6.

vstinner approved these changes Aug 9, 2024

View reviewed changes

Fix typo: kiB -> KiB

1957cfb

corona10 approved these changes Aug 14, 2024

View reviewed changes

corona10 merged commit 432c419 into psf:main Aug 15, 2024
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use KiB and MiB as units instead of kB and MB. #199

Use KiB and MiB as units instead of kB and MB. #199

yngvem commented Aug 9, 2024

vstinner left a comment

Use KiB and MiB as units instead of kB and MB. #199

Use KiB and MiB as units instead of kB and MB. #199

Conversation

yngvem commented Aug 9, 2024

vstinner left a comment

Choose a reason for hiding this comment