Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'kwargs' to browser launch function #499

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add 'kwargs' to browser launch function #499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions requests_html.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,7 +757,7 @@ class BaseSession(requests.Session):
"""

def __init__(self, mock_browser : bool = True, verify : bool = True,
browser_args : list = ['--no-sandbox']):
browser_args : list = ['--no-sandbox'], **browser_kwargs):
super().__init__()

# Mock a web browser's user agent.
Expand All @@ -767,6 +767,7 @@ def __init__(self, mock_browser : bool = True, verify : bool = True,
self.hooks['response'].append(self.response_hook)
self.verify = verify

self.__browser_kwargs = browser_kwargs
self.__browser_args = browser_args


Expand All @@ -779,7 +780,7 @@ def response_hook(self, response, **kwargs) -> HTMLResponse:
@property
async def browser(self):
if not hasattr(self, "_browser"):
self._browser = await pyppeteer.launch(ignoreHTTPSErrors=not(self.verify), headless=True, args=self.__browser_args)
self._browser = await pyppeteer.launch(ignoreHTTPSErrors=not(self.verify), headless=True, args=self.__browser_args, **self.__browser_kwargs)

return self._browser

Expand Down