Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPS proxy support #1512

Closed
wants to merge 5 commits into from
Closed

HTTPS proxy support #1512

wants to merge 5 commits into from

Conversation

schlamar
Copy link
Contributor

@schlamar schlamar commented Aug 1, 2013

HTTPS proxy support finally made it into urllib3 (urllib3/urllib3#170), this is a patch for requests to support it.

Anorov
Anorov reviewed Aug 1, 2013
View reviewed changes
requests/packages/urllib3/poolmanager.py
Behaves just like :class:`PoolManager`, but sends all requests through
the defined proxy, using the CONNECT method for HTTPS URLs.

:param poxy_url:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say this is not an issue which needs to be solved for this PR. Can you send a PR to urllib3? :)

@andr0s
Copy link

andr0s commented Aug 2, 2013

Finally! I spent 4 hours playing with openssl and different combinations of requests itself and different forked urllib3's... I'm happy it looks everything is working fine now.

@Lukasa
Copy link
Member

Lukasa commented Aug 2, 2013

This is a great PR. =) One suggestion: it might be better to raise it against the 2.0 branch.

@sigmavirus24
Copy link
Contributor

This is a great PR. =) One suggestion: it might be better to raise it against the 2.0 branch.

x2

@schlamar
Copy link
Contributor Author

schlamar commented Aug 2, 2013

Is there an ETA for 2.0 release?

@Lukasa
Copy link
Member

Lukasa commented Aug 3, 2013

Not too far in the future. AFAIK we're not planning to have another point release before then. =)

@schlamar
Copy link
Contributor Author

schlamar commented Aug 3, 2013

Not too far in the future. AFAIK we're not planning to have another point release before then. =)

So why is there a separate branch at all? :)

@schlamar
Copy link
Contributor Author

schlamar commented Aug 3, 2013

However, here we go: https://github.com/kennethreitz/requests/pull/1515

@schlamar schlamar closed this Aug 3, 2013
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@schlamar @andr0s @Lukasa @sigmavirus24 @Anorov