-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin to httpbin 0.5.0. #4261
Pin to httpbin 0.5.0. #4261
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4261 +/- ##
=======================================
Coverage 88.66% 88.66%
=======================================
Files 18 18
Lines 2021 2021
=======================================
Hits 1792 1792
Misses 229 229 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is a really crazy rabbit hole - I think @Lukasa is actually more up what's going on than I. I think the problem is caused by this commit to httpbin by @kennethreitz: which is an attempt to fix kennethreitz/httpbin#340 BUT I think it only fixes it on Gunicorn? And pytest-httpbin uses werkzeug which has chunked encoding issues so it ends up causing problems: pallets/werkzeug#1149 |
@kevin1024 we can remove that — I don't think it fixed anything. |
@kennethreitz sweet, I think this problem should magically disappear in that case 🌟 |
The release of httpbin 0.6.0 seems to have broken pytest-httpbin in a surprising way. We want to pin that version out, and probably also alert @kevin1024 about the problem.
Resolves #4259.