Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to httpbin 0.5.0. #4261

Merged
merged 1 commit into from
Aug 27, 2017
Merged

Pin to httpbin 0.5.0. #4261

merged 1 commit into from
Aug 27, 2017

Conversation

Lukasa
Copy link
Member

@Lukasa Lukasa commented Aug 27, 2017

The release of httpbin 0.6.0 seems to have broken pytest-httpbin in a surprising way. We want to pin that version out, and probably also alert @kevin1024 about the problem.

Resolves #4259.

@codecov-io
Copy link

codecov-io commented Aug 27, 2017

Codecov Report

Merging #4261 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4261   +/-   ##
=======================================
  Coverage   88.66%   88.66%           
=======================================
  Files          18       18           
  Lines        2021     2021           
=======================================
  Hits         1792     1792           
  Misses        229      229

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dcbdb5...3a2ea9d. Read the comment docs.

@Lukasa Lukasa mentioned this pull request Aug 27, 2017
Copy link
Contributor

@sigmavirus24 sigmavirus24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Lukasa Lukasa merged commit f09e462 into psf:master Aug 27, 2017
@Lukasa Lukasa deleted the fix-broken-tests branch August 27, 2017 13:00
kevin1024 added a commit to kevin1024/requests that referenced this pull request Aug 27, 2017
The tests are hanging sometimes, see psf#4259 and psf#4261.  I wonder if it would work to unpin both packages since I think I fixed a bug with pytest-httpbin hanging awhile back.
@kevin1024
Copy link

OK, this is a really crazy rabbit hole - I think @Lukasa is actually more up what's going on than I.

I think the problem is caused by this commit to httpbin by @kennethreitz:

kennethreitz/httpbin@2e94212

which is an attempt to fix kennethreitz/httpbin#340

BUT I think it only fixes it on Gunicorn? And pytest-httpbin uses werkzeug which has chunked encoding issues so it ends up causing problems: pallets/werkzeug#1149

@kennethreitz
Copy link
Contributor

@kevin1024 we can remove that — I don't think it fixed anything.

@kevin1024
Copy link

@kennethreitz sweet, I think this problem should magically disappear in that case 🌟

kevin1024 added a commit to kevin1024/requests that referenced this pull request Aug 27, 2017
The upstream bug has been fixed 

See also: 
* psf#4261
* psf#4258
* psf#4259
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants