Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch AttributeError in utils.super_len #5239

Merged
merged 2 commits into from
Nov 28, 2021
Merged

Catch AttributeError in utils.super_len #5239

merged 2 commits into from
Nov 28, 2021

Conversation

dimbleby
Copy link
Contributor

This allows it to handle files obtained via Tarfile.extractfile().

Fixes #5229.

Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change here looks good to me, only need an entry in HISTORY.md.

@nateprewitt nateprewitt added this to the 2.27.0 milestone Nov 28, 2021
This allows it to handle files obtained via `Tarfile.extractfile()`.
@dimbleby
Copy link
Contributor Author

Wow, I had forgotten all about this. Still a good fix though, so I have rebased and added an entry to HISTORY.md

Copy link
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dimbleby!

@nateprewitt nateprewitt merged commit 232a559 into psf:master Nov 28, 2021
nateprewitt pushed a commit to nateprewitt/requests that referenced this pull request Nov 28, 2021
* Catch AttributeError in utils.super_len

This allows it to handle files obtained via `Tarfile.extractfile()`.
@nateprewitt nateprewitt mentioned this pull request Dec 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

requests.utils.super_len() can't cope with tarfile members
3 participants