Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop monkeypatching with pyopenssl #5477

Closed
wants to merge 1 commit into from
Closed

Drop monkeypatching with pyopenssl #5477

wants to merge 1 commit into from

Conversation

WhyNotHugo
Copy link
Contributor

Monkey patching url3 with pyopenssl 3 is no longer a good idea nor even necessary, and actually has security drawbacks, as described in #5267.

This also undoes the changes I initially made in #1347, so I guess it means my previous contribution has completed its life cycle.

Monkey patching url3 with pyopenssl 3 is no longer a good idea. It's
no longer really necessary, and actually has security drawbacks.

Fixes #5267

This commit reverts 50e5922.
@nateprewitt
Copy link
Member

Hi @WhyNotHugo,

This was already addressed in #5443 and left patching as a potential fallback for now for older versions of Python 2.7. This patch has some additional removals from our debugging helper function that I don't think we want to remove. I think we'll pass on this for now.

@WhyNotHugo
Copy link
Contributor Author

Oh, I was under the impression that Python2 was being dropped anyway.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants