Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerate bad registry entries in Windows proxy settings #6149

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

nateprewitt
Copy link
Member

This PR will address #6104. Requests will now handle bad registry entries more gracefully when checking proxy settings from the host. When invalid entries are encountered, the ProxyEnabled setting will be ignored as if they didn't exist rather than throwing an exception.

@nateprewitt
Copy link
Member Author

Looks like 3.11 test failure is related to pytest-dev/pytest#10008.

Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nateprewitt nateprewitt merged commit 210095f into psf:main Jun 1, 2022
@nateprewitt nateprewitt deleted the proxy_bypass_reg_fix branch June 1, 2022 17:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants