Fix HTTPS websites with system-wide HTTP proxy on Windows #6162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to urllib bug, requests fails to open any HTTPS websites on Windows
if there's system-wide HTTP proxy configured. This is because urllib
incorrectly prepends the protocol to the proxy host and port, as in:
{'http': 'http://host:port',
'https': 'https://host:port',
'ftp': 'ftp://host:port'}
Such configuration forces urllib3 to use HTTPS proxy (Secure Web Proxy,
also known as TLS Proxy) for HTTPS URLs, which the configured proxy
most likely does not support.
Detect incorrect behavior and rewrite the protocol to http.
|
Issue #6139 |
sigmavirus24
requested changes
Jun 11, 2022
| @@ -816,6 +816,25 @@ def get_proxy(key): | |||
| return False | |||
|
|
|||
|
|
|||
| def getproxies_fix_system_proxies_windows(): | |||
| """Fix for urllib getproxies() bug on Windows with Python < 3.10.5 | |||
| See: https://bugs.python.org/issue42627 | |||
There was a problem hiding this comment.
Nothing precludes this from running on the versions unaffected according to you. This comment is aside from whether this is the correct fix
There was a problem hiding this comment.
This is a no-op for a fixed Python/urllib version. This commit checks whether getproxies() returns the same proxy host and port for three protocols, each prefixed with the protocol, and rewrites it to "http://". The fixed urllib already returns proxies with "http://", so this commit does nothing in this case.
There was a problem hiding this comment.
@sigmavirus24, do you think the code needs more checks?
9 tasks
|
Could anyone take a look at this merge request please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to urllib bug, requests fails to open any HTTPS websites on Windows
if there's system-wide HTTP proxy configured. This is because urllib
incorrectly prepends the protocol to the proxy host and port, as in:
Such configuration forces urllib3 to use HTTPS proxy (Secure Web Proxy,
also known as TLS Proxy) for HTTPS URLs, which the configured proxy
most likely does not support.
Detect incorrect behavior and rewrite the protocol to http.