Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed warnings message to suggest using secure protocol. #6188

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Fixed warnings message to suggest using secure protocol. #6188

merged 1 commit into from
Jun 29, 2022

Conversation

slyapustin
Copy link
Contributor

Small update to suggest secure schema in the error message:

Perhaps you meant https://

Instead of

Perhaps you meant http://

nateprewitt
nateprewitt approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @slyapustin, I agree this is a better default suggestion.

@nateprewitt nateprewitt merged commit bda7f01 into psf:main Jun 29, 2022
@nateprewitt nateprewitt mentioned this pull request Jan 11, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nateprewitt nateprewitt nateprewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slyapustin @nateprewitt