Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rephrase an outdated comment mentioning Python 2. #6200

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Rephrase an outdated comment mentioning Python 2. #6200

merged 1 commit into from
Jul 20, 2022

Conversation

mila
Copy link
Contributor

@mila mila commented Jul 19, 2022

As a first-time contributor, I was confused when I run make test and saw "This runs all of the tests, on both Python 2 and Python 3." in console output.

@mila
Rephrase an outdated comment mentioning Python 2.
bdaf256 
tox.ini has no longer Python 2 in its envlist.
nateprewitt
nateprewitt approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mila

@nateprewitt nateprewitt merged commit 7862556 into psf:main Jul 20, 2022
@mila mila deleted the fix-outdated-comment branch August 7, 2022 21:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nateprewitt nateprewitt nateprewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mila @nateprewitt