Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reenable the warnings plugin #6416

Merged
merged 1 commit into from
Apr 23, 2023
Merged

reenable the warnings plugin #6416

merged 1 commit into from
Apr 23, 2023

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Apr 21, 2023

The warnings plugin was disabled in #4056 but that issue is now fixed by
pytest-dev/pytest#2445

@graingert graingert changed the title enable the warnings plugin reenable the warnings plugin Apr 21, 2023
@nateprewitt
Copy link
Member

Thanks Thomas, I'll kick the failed test once the rest finish. If they're all working this seems fine.

@nateprewitt
Copy link
Member

Hmm, the failure seems reproducible but unrelated. It's localized to Pypy with:

Fatal Python error: Aborted

Stack (most recent call first, approximate line numbers):
  File "<frozen importlib._bootstrap>", line 220 in _call_with_frames_removed

We haven't made any changes that would have affected this, so I'm assuming it's either a GH CI issue or an underlying test depenency isn't playing nicely with Pypy anymore.

I'm fine ignoring for this PR while we track that separately.

@graingert
Copy link
Contributor Author

Looks like the 18.04 runners aren't getting picked up anymore: #6417

@graingert
Copy link
Contributor Author

Hmm, the failure seems reproducible but unrelated. It's localized to Pypy with:

Fatal Python error: Aborted

Stack (most recent call first, approximate line numbers):
  File "<frozen importlib._bootstrap>", line 220 in _call_with_frames_removed

We haven't made any changes that would have affected this, so I'm assuming it's either a GH CI issue or an underlying test depenency isn't playing nicely with Pypy anymore.

I'm fine ignoring for this PR while we track that separately.

@nateprewitt I think failing due to trustme's dep on cryptography #6419 (comment)

@graingert
Copy link
Contributor Author

@nateprewitt yep it was cryptography, here's the fix #6421

@graingert graingert closed this Apr 22, 2023
@graingert graingert reopened this Apr 22, 2023
Copy link
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again Thomas for taking the time to debug the chain of issues to get the PR working. Really appreciate it! I'll merge after tests finish and we should be good now.

@nateprewitt nateprewitt merged commit 51716c4 into psf:main Apr 23, 2023
@graingert graingert deleted the patch-6 branch April 23, 2023 10:10
matthewarmand pushed a commit to matthewarmand/requests that referenced this pull request May 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants